Skip to content

fix: clearing heartbeats on paused monitors leaves them paused#6897

Merged
louislam merged 4 commits intolouislam:masterfrom
bruce691:fix/clear-heartbeats-paused
Feb 18, 2026
Merged

fix: clearing heartbeats on paused monitors leaves them paused#6897
louislam merged 4 commits intolouislam:masterfrom
bruce691:fix/clear-heartbeats-paused

Conversation

@bruce691
Copy link
Copy Markdown
Contributor

@bruce691 bruce691 commented Feb 9, 2026

Summary

In this pull request, the following changes are made:

  • Prevent clearHeartbeats from restarting a paused monitor by only restarting when the monitor is still active in the database.
Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Screenshots for Visual Changes

fix_result.mp4

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2026

Hello and thanks for lending a paw to Uptime Kuma! 🐻👋
As this is your first contribution, please be sure to check out our Pull Request guidelines.
In particular: - Mark your PR as Draft while you’re still making changes - Mark it as Ready for review once it’s fully ready
If you have any design or process questions, feel free to ask them right here in this pull request - unclear documentation is a bug too.

@bruce691 bruce691 marked this pull request as draft February 9, 2026 18:14
@bruce691 bruce691 marked this pull request as ready for review February 9, 2026 18:15
@github-actions github-actions bot added the pr:needs review this PR needs a review by maintainers or other community members label Feb 9, 2026
@bruce691 bruce691 marked this pull request as draft February 9, 2026 18:19
@CommanderStorm CommanderStorm changed the title Fix/clear heartbeats paused fix: clearing heartbeats on paused monitors leaves them paused Feb 9, 2026
@bruce691 bruce691 marked this pull request as ready for review February 9, 2026 18:28
@bruce691
Copy link
Copy Markdown
Contributor Author

bruce691 commented Feb 9, 2026

Thanks @CommanderStorm

@louislam louislam added this to the 2.1.2 milestone Feb 18, 2026
@louislam
Copy link
Copy Markdown
Owner

louislam commented Feb 18, 2026 •
edited
Loading

It is fixed partially. Let me finish the missing part. Also I don't like the monitor object got from db again.

@louislam louislam enabled auto-merge (squash) February 18, 2026 05:48
@louislam louislam merged commit 193eb3b into louislam:master Feb 18, 2026
24 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 18, 2026

@bruce691 congrats on your first contribution to Uptime Kuma! 🐻
We hope you enjoy contributing to our project and look forward to seeing more of your work in the future! If you want to see your contribution in action, please see our nightly builds here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr:needs review this PR needs a review by maintainers or other community members

Projects

None yet

Milestone

2.1.2

Development

Successfully merging this pull request may close these issues.

Bug: Monitor restarts after deleting heartbeats while paused

2 participants

@bruce691 @louislam